Skip to content

tests: Move langchain under toxgen #4734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 2, 2025
Merged

tests: Move langchain under toxgen #4734

merged 8 commits into from
Sep 2, 2025

Conversation

@sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Sep 2, 2025 •
edited
Loading

  • move the langchain test suites to be governed by toxgen
    • this indirectly results in removing the -latest tests in the AI group 🎉
      • -latest tests predate toxgen and langchain was the last non-toxgen test suite (the rest was just skipped) -- all AI tests are now pinned
  • updated the naming scheme to use dashes instead of underscores for variants so that it's clearer if something is part of the name of the integration or if it denotes a variant
    • for instance, openai-base means this is the base variant of the openai test suite, but openai_agents means this is the openai_agents test suite (no variant)

I'm explicitly ignoring the two alpha versions of 1.0 since adapting the integration to work with those is out of scope: dedicated issue

Part of #4506

@codecov
Copy link

codecov bot commented Sep 2, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
23940 1 23939 2291
View the top 1 failed test(s) by shortest run time 
tests.integrations.wsgi.test_wsgi::test_auto_session_tracking_with_aggregates
Stack Traces | 0.095s run time 
.../integrations/wsgi/test_wsgi.py:430: in test_auto_session_tracking_with_aggregates
    assert session_aggregates[0]["crashed"] == 1
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E   KeyError: 'crashed'

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@sentrivana sentrivana marked this pull request as ready for review September 2, 2025 09:25
@sentrivana sentrivana requested a review from a team as a code owner September 2, 2025 09:25
cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

@sentrivana sentrivana marked this pull request as draft September 2, 2025 09:42
cursor[bot]

This comment was marked as outdated.

Sign in to view

@sentrivana sentrivana mentioned this pull request Sep 2, 2025
Closed
@sentrivana sentrivana marked this pull request as ready for review September 2, 2025 11:13
cursor[bot]
cursor bot reviewed Sep 2, 2025
View reviewed changes
@sentrivana sentrivana merged commit 65755f9 into master Sep 2, 2025
139 of 141 checks passed
@sentrivana sentrivana deleted the ivana/toxgen/move-langchain branch September 2, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@alexander-alderman-webb alexander-alderman-webb alexander-alderman-webb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sentrivana @alexander-alderman-webb